fix: Remove alerting for confirm-traffic-increase webhook #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the issue?
The
confirm-traffic-increasewebhook is used to manually approve each time you want to increase the weight on the Canary. When alerting is enabled along with this webhook, way too many alerts are generated while the Canary is waits for this webhooks to suceed. This, multiplied with the number of steps your Canary takes could potentially lead to a spam of alerts.What is the fix?
This PR removes alerting for
confirm-traffic-webhook. Even if we do find a way to alert only once per step, it becomes too noisy if the number of steps your Canary takes increases.Alternatives considered
If there's a chance that users find alerting useful for this webhook, we should instead find a way to mute alerts for specific webhooks. That way, users have the flexibility of muting alerts from Flagger for the
confirm-traffic-increasewebhook.See - #887
Signed-off-by: Mayank Shah [email protected]